Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input singleton is not highlighted in the script editor #37319

Closed
Xrayez opened this issue Mar 26, 2020 · 0 comments · Fixed by #38295
Closed

Input singleton is not highlighted in the script editor #37319

Xrayez opened this issue Mar 26, 2020 · 0 comments · Fixed by #38295
Labels
bug topic:editor
Milestone
4.0

Comments

@Xrayez
Copy link
Contributor

Xrayez commented Mar 26, 2020 •
edited
Loading

Godot version:
4.0-dev after #37317.

OS/device including version:
Windows 10

Issue description:
godot-input-filter

Steps to reproduce:

extends Node2D

func _physics_process(delta):
	if Input.is_action_pressed("ui_accept"):
		print("jump")
	if InputFilter.is_action_pressed("ui_accept"):
		print("jump")

Minimal reproduction project:
input-not-highlighted.zip
@Xrayez Xrayez changed the title Input singleton is not highlighted in script editor Input singleton is not highlighted in the script editor Apr 4, 2020
@akien-mga akien-mga added this to the 4.0 milestone Apr 28, 2020
akien-mga added a commit to akien-mga/godot that referenced this issue Apr 28, 2020
@akien-mga
Rename InputFilter back to Input
fdf58a5 
It changed name as part of the DisplayServer and input refactoring
in godotengine#37317, with the rationale that input no longer goes through the
main loop, so the previous Input singleton now only does filtering.

But the gains in consistency are quite limited in the renaming, and
it breaks compatibility for all scripts and tutorials that access
the Input singleton via the scripting language. A temporary option
was suggested to keep the scripting singleton named `Input` even if
its type is `InputFilter`, but that adds inconsistency and breaks C#.

Fixes godotengine/godot-proposals#639.
Fixes godotengine#37319.
Fixes godotengine#37690.
@akien-mga akien-mga mentioned this issue Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Rename InputFilter back to Input akien-mga/godot
3 participants
@Calinou @akien-mga @Xrayez