Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line export prints unspecific error if template missing #18470

Closed
AlexHolly opened this issue Apr 27, 2018 · 6 comments · Fixed by #18506 or #34887
Closed

Command line export prints unspecific error if template missing #18470

AlexHolly opened this issue Apr 27, 2018 · 6 comments · Fixed by #18506 or #34887

Comments

@AlexHolly
Copy link
Contributor

Godot Master

Happens with Linux and Windows probably the others too.

Command
godot_server.server.tools.64 --export "Windows Desktop" ./../exports/test.exe

ERROR: copy: Failed to open - means the templates are missing(in my case). It would be nice to get a more specific error message.

./godot_server.server.tools.64
ERROR: copy: Failed to open 
   At: core/os/dir_access.cpp:304.
ERROR: _fs_changed: Project export failed with error code 12.
   At: editor/editor_node.cpp:494.
@AlexHolly AlexHolly changed the title Server headless export bad errir if template missing Server headless export bad error if template missing Apr 27, 2018
@akien-mga akien-mga added this to the 3.1 milestone May 1, 2018
@akien-mga akien-mga reopened this May 1, 2018
@akien-mga
Copy link
Member

Reverted with 007d175, I'll work on a better error handling.

@akien-mga akien-mga self-assigned this May 1, 2018
@h4de5
Copy link

h4de5 commented Jul 1, 2018

@AlexHolly : do you know where i have to put the export templates so the godot_server finds it?

@AlexHolly
Copy link
Contributor Author

AlexHolly commented Jul 1, 2018

@h4de5 Are you on a linux mashine? And master branch?

~/.local/share/godot/templates/3.1.dev/

@h4de5
Copy link

h4de5 commented Jul 1, 2018

@AlexHolly : thank you, very much! i just managed to get a valid export on WSL (ubuntu 18.03) using your path and the older 3.0.2 version. it seems its broken from 3.0.3 onwards... took me a while.

@AlexHolly

This comment has been minimized.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Jan 22, 2019
@akien-mga akien-mga removed this from the 3.2 milestone Jan 5, 2020
@akien-mga
Copy link
Member

Still fails the same way in the current master branch.

@akien-mga akien-mga changed the title Server headless export bad error if template missing Command line export prints unspecific error if template missing Jan 7, 2020
@akien-mga akien-mga added this to the 3.2 milestone Jan 7, 2020
akien-mga added a commit to akien-mga/godot that referenced this issue Jan 7, 2020
I'm barely scratching the surface of the changes needed to make the
--export command line interface easy to use, but this should already
improve things somewhat.

- Streamline `can_export()` templates check in all platforms, checking
  first for the presence of official templates, then of any defined
  custom template, and reporting on the absence of any.
  Shouldn't change the actual return value much which is still true if
  either release or debug is usable - we might want to change that
  eventually and better validate against the requested target.

- Fix discrepancy between platforms using `custom_package/debug` and
  `custom_template/debug` (resp. `release`).
  All now use `custom_template`, which will break compatibility for
  `export_presets.cfg` with earlier projects (but is easy to fix).

- Use `can_export()` when attempting a command line export and report
  the same errors that would be shown in the editor.

- Improve error reporting after a failed export attempt, handling
  missing template and invalid path more gracefully.

- Cleanup of unused stuff in EditorNode around the export workflow.

- Improve --export documentation in --help a bit.

Fixes godotengine#16949 (at least many of the misunderstandings listed there).
Fixes godotengine#18470.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment