Performance regression from 4.4 to 4.5.beta3 in large scene with lots of nodes

[Jamsers]

Tested versions

-Reproducible in: v4.5.beta3.official
-Not reproducible in: v4.4.1.stable.official

System information

Godot v4.5.beta3 - Ubuntu 24.04.2 LTS 24.04 on Wayland - Wayland display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU - AMD Ryzen 5 5600H with Radeon Graphics (12 threads) - 14.48 GiB memory

Issue description

Sizable performance regression in a large scene with lots of nodes.

This is a degenerate case however, an unoptimized work-in-progress scene with an excessive amount of nodes that you likely wouldn't find in a normal project.

On my Ideapad Gaming 3 laptop:
v4.4.1: 35 FPS
v4.5.beta3: 10 FPS

Edit: Bisecting shows performance regression was introduced with ae04a3a.

Steps to reproduce

Open Crater-Province-Level/test-4.5 in Godot 4.4.1 and run the project. Note the FPS.
Then open Crater-Province-Level/test-4.5 in Godot 4.5.beta3 and run the project. Note the FPS.

Minimal reproduction project (MRP)

Crater-Province-Level/test-4.5

[clayjohn]

Did you narrow down the issue to having lots of lights? In other words, if you hide the lights does the performance regression go away?

[Jamsers]

Sorry no I was just describing the scene, I don't actually know what specific part of the engine has regressed in performance

[Jamsers]

Bisecting shows regression was introduced with ae04a3a. So I guess it's the excessive amount of nodes triggering the regression 😅

[precup]

This looked very similar to #108435, which was fixed in #108459. I tested locally and the same fix seems to work here, too. It's already landed, so you should be fine if you use the latest master.

[hsvfan-jan]

@precup In #108435 you said it bisected to #106661 which is different from the bisection #104269 mentioned here