Wrong color presets displayed after saving color palette with multiple ColorPickers in the scene

[FeniXb3]

Tested versions

• Reproducible in: 4.4 (and previous 4.4.dev builds since saving color palettes was introduced Save color palette as resources to reuse later #91604)

System information

Godot v4.4.stable - Windows 11 (build 26100) - Multi-window, 1 monitor - Vulkan (Forward+) - integrated AMD Radeon 780M Graphics (Advanced Micro Devices, Inc.; 32.0.11039.8001) - AMD Ryzen 7 8845HS w/ Radeon 780M Graphics (16 threads)

Issue description

If you have multiple ColorPickers in the scene and each has some color presets, and you will save one as color palette, presets from all ColorPickers will be displayed as colors of this palette. However, the saved palette has only presets from the ColorPicker that was used to save it.

Nagrywanie.ekranu.2025-03-16.095710.mp4

From the code it seems to be a problem with using preset_cache in ColorPicker to display colors, which is static.

Steps to reproduce

1. Add 2 or more ColorPickers to the scene
2. Assign different colors to each ColorPicker
3. Run the game
4. Open Swatches in each ColorPicker and add current color to presets
5. Save presets of one ColorPicker as color palette
6. You should see colors from all ColorPickers displayed as the palette in the one where you saved presets

Minimal reproduction project (MRP)

regression-test-project.zip

[FeniXb3]

I would love to work on it, but I see at few different ways to handle this and I am not sure what would be best for most users:

1. Separate saved palettes from preset_cache to isolate ones using saved palettes from those not using them
2. Make using saved color palette in one ColorPicker to propagate to all pickers in the scene
3. Give the player option to choose the behaviour each time when saving the palette
4. Make it configurable in the node so that game creator can decide

I have seen that in the editor the palette is synced across all ColorPickers, but I am not sure if it would be a good solution to force it in games.

[FeniXb3]

Issues with wrong colors occur also when changing theme during runtime in game:

Nagrywanie.ekranu.2025-03-22.234842.mp4

Nagrywanie.ekranu.2025-03-22.235008.mp4