[macOS] Use occlusionState instead of isOnActiveSpace to determine wh…

…en window is drawable.
godotengine · Oct 10, 2023 · 3620d61 · 3620d61
1 parent b931a6e
commit 3620d61
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/platform/macos/display_server_macos.h b/platform/macos/display_server_macos.h
@@ -119,6 +119,7 @@ class DisplayServerMacOS : public DisplayServer {
 		bool is_popup = false;
 		bool mpass = false;
 		bool focused = false;
+		bool is_visible = true;
 
 		Rect2i parent_safe_rect;
 	};

diff --git a/platform/macos/display_server_macos.mm b/platform/macos/display_server_macos.mm
@@ -3562,14 +3562,14 @@ - (void)popupAction:(id)sender {
 }
 
 bool DisplayServerMacOS::window_can_draw(WindowID p_window) const {
-	return (window_get_mode(p_window) != WINDOW_MODE_MINIMIZED) && [windows[p_window].window_object isOnActiveSpace];
+	return windows[p_window].is_visible;
 }
 
 bool DisplayServerMacOS::can_any_window_draw() const {
 	_THREAD_SAFE_METHOD_
 
 	for (const KeyValue<WindowID, WindowData> &E : windows) {
-		if ((window_get_mode(E.key) != WINDOW_MODE_MINIMIZED) && [E.value.window_object isOnActiveSpace]) {
+		if (E.value.is_visible) {
 			return true;
 		}
 	}

diff --git a/platform/macos/godot_window_delegate.mm b/platform/macos/godot_window_delegate.mm
@@ -356,4 +356,13 @@ - (void)windowDidDeminiaturize:(NSNotification *)notification {
 	}
 }
 
+- (void)windowDidChangeOcclusionState:(NSNotification *)notification {
+	DisplayServerMacOS *ds = (DisplayServerMacOS *)DisplayServer::get_singleton();
+	if (!ds || !ds->has_window(window_id)) {
+		return;
+	}
+	DisplayServerMacOS::WindowData &wd = ds->get_window(window_id);
+	wd.is_visible = ([wd.window_object occlusionState] & NSWindowOcclusionStateVisible) && [wd.window_object isVisible];
+}
+
 @end