Merge pull request #48029 from Calinou/gdscript-add-integration-tests

Add dozens of new integration tests to the GDScript test suite

misc/scripts/file_format.sh

@@ -20,6 +20,9 @@ while IFS= read -rd '' f; do
         continue
     elif [[ "$f" == *"sln" ]]; then
         continue
+    elif [[ "$f" == *".out" ]]; then
+        # GDScript integration testing files.
+        continue
     elif [[ "$f" == *"patch" ]]; then
         continue
     elif [[ "$f" == *"pot" ]]; then

modules/gdscript/tests/scripts/analyzer/errors/bitwise_float_left_operand.gd

@@ -0,0 +1,3 @@
+func test():
+	# Error here.
+	print(2.2 << 4)

modules/gdscript/tests/scripts/analyzer/errors/bitwise_float_left_operand.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid operands to operator <<, float and int.

modules/gdscript/tests/scripts/analyzer/errors/bitwise_float_right_operand.gd

@@ -0,0 +1,3 @@
+func test():
+	# Error here.
+	print(2 << 4.4)

modules/gdscript/tests/scripts/analyzer/errors/bitwise_float_right_operand.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid operands to operator <<, int and float.

modules/gdscript/tests/scripts/analyzer/errors/constant_used_as_function.gd

@@ -0,0 +1,5 @@
+const CONSTANT = 25
+
+
+func test():
+	CONSTANT(123)

modules/gdscript/tests/scripts/analyzer/errors/constant_used_as_function.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Member "CONSTANT" is not a function.

modules/gdscript/tests/scripts/analyzer/errors/enum_float_value.gd

@@ -0,0 +1,7 @@
+enum Size {
+	# Error here. Enum values must be integers.
+	S = 0.0,
+}
+
+func test():
+	pass

modules/gdscript/tests/scripts/analyzer/errors/enum_float_value.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Enum values must be integers.

modules/gdscript/tests/scripts/analyzer/errors/enum_string_value.gd

@@ -0,0 +1,7 @@
+enum Size {
+	# Error here. Enum values must be integers.
+	S = "hello",
+}
+
+func test():
+	pass

modules/gdscript/tests/scripts/analyzer/errors/enum_string_value.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Enum values must be integers.

modules/gdscript/tests/scripts/analyzer/errors/function_used_as_property.gd

@@ -0,0 +1,6 @@
+func function():
+	pass
+
+
+func test():
+	function = 25

modules/gdscript/tests/scripts/analyzer/errors/function_used_as_property.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Cannot assign a new value to a constant.

modules/gdscript/tests/scripts/analyzer/errors/invalid_array_index.gd

@@ -0,0 +1,3 @@
+func test():
+	# Error here. Array indices must be integers.
+	print([0, 1][true])

modules/gdscript/tests/scripts/analyzer/errors/invalid_array_index.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid index type "bool" for a base of type "Array".

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_bool.gd

@@ -0,0 +1,2 @@
+func test():
+	print(true + true)

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_bool.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid operands to operator +, bool and bool.

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_dictionary.gd

@@ -0,0 +1,2 @@
+func test():
+	print({"hello": "world"} + {"godot": "engine"})

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_dictionary.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid operands "Dictionary" and "Dictionary" for "+" operator.

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_mixed.gd

@@ -0,0 +1,2 @@
+func test():
+	print("hello" + ["world"])

modules/gdscript/tests/scripts/analyzer/errors/invalid_concatenation_mixed.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Invalid operands "String" and "Array" for "+" operator.

modules/gdscript/tests/scripts/analyzer/errors/invalid_constant.gd

@@ -0,0 +1,5 @@
+func test():
+	var i = 12
+	# Constants must be made of a constant, deterministic expression.
+	# A constant that depends on a variable's value is not a constant expression.
+	const TEST = 13 + i

modules/gdscript/tests/scripts/analyzer/errors/invalid_constant.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Assigned value for constant "TEST" isn't a constant expression.

modules/gdscript/tests/scripts/analyzer/errors/leading_number_separator.gd

@@ -0,0 +1,3 @@
+func test():
+	# Number separators may not be placed at the beginning of a number.
+	var __ = _123

modules/gdscript/tests/scripts/analyzer/errors/leading_number_separator.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Identifier "_123" not declared in the current scope.

modules/gdscript/tests/scripts/analyzer/errors/missing_argument.gd

@@ -0,0 +1,6 @@
+func args(a, b):
+	print(a)
+	print(b)
+
+func test():
+	args(1,)

modules/gdscript/tests/scripts/analyzer/errors/property_used_as_function.gd

@@ -0,0 +1,4 @@
+var property = 25
+
+func test():
+	property()

modules/gdscript/tests/scripts/analyzer/errors/property_used_as_function.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Member "property" is not a function.

modules/gdscript/tests/scripts/analyzer/errors/redefine_class_constant.gd

@@ -0,0 +1,7 @@
+# See also `parser-warnings/shadowed-constant.gd`.
+const TEST = 25
+
+
+func test():
+	# Error here (trying to set a new value to a constant).
+	TEST = 50

modules/gdscript/tests/scripts/analyzer/errors/redefine_class_constant.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Cannot assign a new value to a constant.

modules/gdscript/tests/scripts/analyzer/errors/redefine_local_constant.gd

@@ -0,0 +1,5 @@
+func test():
+	const TEST = 25
+
+	# Error here (can't assign a new value to a constant).
+	TEST = 50

modules/gdscript/tests/scripts/analyzer/errors/redefine_local_constant.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Cannot assign a new value to a constant.

modules/gdscript/tests/scripts/analyzer/errors/super_nonexistent_base_method.gd

@@ -0,0 +1,11 @@
+# `class` extends RefCounted by default.
+class Say:
+	func say():
+		super()
+		print("say something")
+
+
+func test():
+	# RefCounted doesn't have a `say()` method, so the `super()` call in the method
+	# definition will cause a run-time error.
+	Say.new().say()

modules/gdscript/tests/scripts/analyzer/errors/super_nonexistent_base_method.out

@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Function "say()" not found in base RefCounted.

modules/gdscript/tests/scripts/analyzer/features/as.gd

@@ -0,0 +1,16 @@
+func test():
+	var some_bool = 5 as bool
+	var some_int = 5 as int
+	var some_float = 5 as float
+	print(typeof(some_bool))
+	print(typeof(some_int))
+	print(typeof(some_float))
+
+	print()
+
+	var some_bool_typed := 5 as bool
+	var some_int_typed := 5 as int
+	var some_float_typed := 5 as float
+	print(typeof(some_bool_typed))
+	print(typeof(some_int_typed))
+	print(typeof(some_float_typed))

modules/gdscript/tests/scripts/analyzer/features/as.out

@@ -0,0 +1,8 @@
+GDTEST_OK
+1
+2
+3
+
+1
+2
+3

modules/gdscript/tests/scripts/parser/errors/array_consecutive_commas.gd

@@ -0,0 +1,3 @@
+func test():
+	# Arrays with consecutive commas are not allowed.
+	var array = ["arrays",,,,]

modules/gdscript/tests/scripts/parser/errors/array_consecutive_commas.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected expression as array element.

modules/gdscript/tests/scripts/parser/errors/assignment_2_equal_signs.gd

@@ -0,0 +1,2 @@
+func test():
+	var hello == "world"

modules/gdscript/tests/scripts/parser/errors/assignment_2_equal_signs.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected end of statement after variable declaration, found "==" instead.

modules/gdscript/tests/scripts/parser/errors/assignment_3_equal_signs.gd

@@ -0,0 +1,2 @@
+func test():
+	var hello === "world"

modules/gdscript/tests/scripts/parser/errors/assignment_3_equal_signs.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected end of statement after variable declaration, found "==" instead.

modules/gdscript/tests/scripts/parser/errors/assignment_in_if.gd

@@ -0,0 +1,4 @@
+func test():
+	# Error here.
+	if foo = 25:
+		print(foo)

modules/gdscript/tests/scripts/parser/errors/assignment_in_if.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Assignment is not allowed inside an expression.

modules/gdscript/tests/scripts/parser/errors/assignment_in_var.gd

@@ -0,0 +1,2 @@
+func test():
+	var hello = "world" = "test"

modules/gdscript/tests/scripts/parser/errors/assignment_in_var.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Assignment is not allowed inside an expression.

modules/gdscript/tests/scripts/parser/errors/assignment_in_var_if.gd

@@ -0,0 +1,4 @@
+func test():
+	# Error here.
+	if var foo = 25:
+		print(foo)

modules/gdscript/tests/scripts/parser/errors/assignment_in_var_if.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected conditional expression after "if".

modules/gdscript/tests/scripts/parser/errors/assignment_without_identifier.gd

@@ -0,0 +1,2 @@
+func test():
+	var = "world"

modules/gdscript/tests/scripts/parser/errors/assignment_without_identifier.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected variable name after "var".

modules/gdscript/tests/scripts/parser/errors/class_name_after_annotation.gd

@@ -0,0 +1,6 @@
+# Error here. `class_name` should be used *before* annotations, not after.
+@icon("res://path/to/optional/icon.svg")
+class_name HelloWorld
+
+func test():
+	pass

modules/gdscript/tests/scripts/parser/errors/class_name_after_annotation.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+"class_name" should be used before annotations.

modules/gdscript/tests/scripts/parser/errors/constant_conflicts_variable.gd

@@ -0,0 +1,3 @@
+func test():
+	var TEST = 50
+	const TEST = 25

modules/gdscript/tests/scripts/parser/errors/constant_conflicts_variable.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+There is already a variable named "TEST" declared in this scope.

modules/gdscript/tests/scripts/parser/errors/default_value_in_function_call.gd

@@ -0,0 +1,7 @@
+func hello(arg1):
+	print(arg1)
+
+
+func test():
+	# Error here.
+	hello(arg1 = 25)

modules/gdscript/tests/scripts/parser/errors/default_value_in_function_call.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Assignment is not allowed inside an expression.

modules/gdscript/tests/scripts/parser/errors/function_conflicts_constant.gd

@@ -0,0 +1,5 @@
+const test = 25
+
+
+func test():
+	pass

modules/gdscript/tests/scripts/parser/errors/function_conflicts_constant.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Function "test" has the same name as a previously declared constant.

modules/gdscript/tests/scripts/parser/errors/function_conflicts_variable.gd

@@ -0,0 +1,7 @@
+func test():
+	pass
+
+
+# Error here. The difference with `variable-conflicts-function.gd` is that here,
+# the function is defined *before* the variable.
+var test = 25

modules/gdscript/tests/scripts/parser/errors/function_conflicts_variable.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Variable "test" has the same name as a previously declared function.

modules/gdscript/tests/scripts/parser/errors/invalid_identifier_number.gd

@@ -0,0 +1,3 @@
+func test():
+	# Error here.
+	var 23test = "is not a valid identifier"

modules/gdscript/tests/scripts/parser/errors/invalid_identifier_number.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected variable name after "var".

modules/gdscript/tests/scripts/parser/errors/invalid_identifier_string.gd

@@ -0,0 +1,3 @@
+func test():
+	# Error here.
+	var "yes" = "is not a valid identifier"

modules/gdscript/tests/scripts/parser/errors/invalid_identifier_string.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected variable name after "var".

modules/gdscript/tests/scripts/parser/errors/missing_closing_expr_paren.gd

@@ -1,2 +1,2 @@
 func test():
-    var a = ("missing paren ->"
+	var a = ("missing paren ->"

modules/gdscript/tests/scripts/parser/errors/missing_colon.gd

@@ -1,3 +1,3 @@
 func test():
-    if true # Missing colon here.
-        print("true")
+	if true # Missing colon here.
+		print("true")

modules/gdscript/tests/scripts/parser/errors/missing_paren_after_args.gd

@@ -1,6 +1,6 @@
 func args(a, b):
-    print(a)
-    print(b)
+	print(a)
+	print(b)
 
 func test():
-    args(1,2
+	args(1,2

modules/gdscript/tests/scripts/parser/errors/multiple_number_separators.gd

@@ -0,0 +1,3 @@
+func test():
+	# Number separators may not be placed right next to each other.
+	var __ = 1__23

modules/gdscript/tests/scripts/parser/errors/multiple_number_separators.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Only one underscore can be used as a numeric separator.

modules/gdscript/tests/scripts/parser/errors/nothing_after_dollar.gd

@@ -1,3 +1,5 @@
 extends Node
+
+
 func test():
-    var a = $ # Expected some node path.
+	var a = $ # Expected some node path.

modules/gdscript/tests/scripts/parser/errors/redefine_keyword.gd

@@ -0,0 +1,2 @@
+func test():
+	var while = "it's been a while"

modules/gdscript/tests/scripts/parser/errors/redefine_keyword.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Expected variable name after "var".

modules/gdscript/tests/scripts/parser/errors/redefine_local_constant_with_keyword.gd

@@ -0,0 +1,5 @@
+func test():
+	const TEST = 25
+
+	# Error here (can't redeclare a constant on the same scope).
+	const TEST = 50

modules/gdscript/tests/scripts/parser/errors/redefine_local_constant_with_keyword.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+There is already a constant named "TEST" declared in this scope.

modules/gdscript/tests/scripts/parser/errors/variable_conflicts_constant.gd

@@ -0,0 +1,3 @@
+func test():
+	const TEST = 25
+	var TEST = 50

modules/gdscript/tests/scripts/parser/errors/variable_conflicts_constant.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+There is already a constant named "TEST" declared in this scope.

modules/gdscript/tests/scripts/parser/errors/variable_conflicts_function.gd

@@ -0,0 +1,6 @@
+var test = 25
+
+# Error here. The difference with `variable-conflicts-function.gd` is that here,
+# the function is defined *before* the variable.
+func test():
+	pass

modules/gdscript/tests/scripts/parser/errors/variable_conflicts_function.out

@@ -0,0 +1,2 @@
+GDTEST_PARSER_ERROR
+Function "test" has the same name as a previously declared variable.

modules/gdscript/tests/scripts/parser/errors/wrong_value_after_dollar.gd

@@ -1,3 +1,5 @@
 extends Node
+
+
 func test():
-    $23 # Can't use number here.
+	$23 # Can't use number here.

modules/gdscript/tests/scripts/parser/errors/wrong_value_after_dollar_slash.gd

@@ -1,3 +1,5 @@
 extends Node
+
+
 func test():
-    $MyNode/23 # Can't use number here.
+	$MyNode/23 # Can't use number here.

modules/gdscript/tests/scripts/parser/features/array.gd

@@ -0,0 +1,16 @@
+func test():
+	# Indexing from the beginning:
+	print([1, 2, 3][0])
+	print([1, 2, 3][1])
+	print([1, 2, 3][2])
+
+	# Indexing from the end:
+	print([1, 2, 3][-1])
+	print([1, 2, 3][-2])
+	print([1, 2, 3][-3])
+
+	# Float indices are currently allowed, but should probably be an error?
+	print([1, 2, 3][0.4])
+	print([1, 2, 3][0.8])
+	print([1, 2, 3][1.0])
+	print([1, 2, 3][-1.0])