Merge pull request #81090 from SysError99/3.x-fix-js-callback-mem-leak

[3.x] Fix JavaScript callback memory leak
godotengine · Sep 6, 2023 · 1012078 · 1012078
2 parents 54738d3 + 8ac91f8
commit 1012078
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/platform/javascript/js/libs/library_godot_javascript_singleton.js b/platform/javascript/js/libs/library_godot_javascript_singleton.js
@@ -205,7 +205,9 @@ const GodotJSWrapper = {
 				return;
 			}
 			const args = Array.from(arguments);
-			func(p_ref, GodotJSWrapper.get_proxied(args), args.length);
+			const argsProxy = new GodotJSWrapper.MyProxy(args);
+			func(p_ref, argsProxy.get_id(), args.length);
+			argsProxy.unref();
 		};
 		id = GodotJSWrapper.get_proxied(cb);
 		return id;