Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.2 beta 1 and publish release notes #728

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Release 4.2 beta 1 and publish release notes #728

merged 2 commits into from
Oct 12, 2023

Conversation

YuriSizov
Copy link
Contributor

Drafting as the release is not ready yet, but this can be reviewed for content and grammar.

@YuriSizov YuriSizov added topic:content Issues and PRs related to static content topic:releases Issues and PRs related to new engine releases topic:blog New blogposts and corrections labels Oct 10, 2023
clayjohn
clayjohn reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work so far! I reviewed the content and made some suggestions.

I know I noted on a few PRs that I wanted to say something in particular in the release post, so I'll go back and look for those notes now.

collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Show resolved Hide resolved
JohnVeness
JohnVeness reviewed Oct 10, 2023
View reviewed changes
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
JohnVeness
JohnVeness reviewed Oct 10, 2023
View reviewed changes
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
JohnVeness
JohnVeness reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@JohnVeness JohnVeness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, very well done on these release notes. The document is enjoyable to read and must have taken you ages to write!

collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
@YuriSizov
Copy link
Contributor Author

Thanks for reviews! Most of it should be addressed now.

and must have taken you ages to write

Just 2-3 days 🙃

clayjohn
clayjohn reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions. One for the attribute compression PR and another dealing with CPUParticles

collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Show resolved Hide resolved
@YuriSizov
Copy link
Contributor Author

I made the changes, but GitHub seems to be experiencing issues and is stuck processing pushed commits.

@YuriSizov
Copy link
Contributor Author

Fixed it! I left the latest change as a separate commit for clarity.

@dalexeev
Copy link
Member

dalexeev commented Oct 12, 2023 •
edited
Loading

I'd like to suggest another image to illustrate the GDScript highlighting changes. The previous image is outdated, it highlights void as a keyword and does not highlight doc comments in a separate color.

The image may be too wide, but we can remove the Godot 2 theme (middle image) and leave only the default and the light themes.

@YuriSizov YuriSizov force-pushed the release-4.2-beta1 branch 2 times, most recently from c25b149 to 38c5ed0 Compare October 12, 2023 10:37
@YuriSizov
Copy link
Contributor Author

It looks more interesting with 3 sections, thanks!

@YuriSizov YuriSizov marked this pull request as ready for review October 12, 2023 10:37
akien-mga
akien-mga reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass down to the Editor section (included).

_data/versions.yml Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review pass down to GUI (included). Have to step out for 30 min, I'll continue then.

collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
@YuriSizov YuriSizov force-pushed the release-4.2-beta1 branch 2 times, most recently from 810ca7c to a4755ba Compare October 12, 2023 12:45
akien-mga
akien-mga approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here is a damn fine write-up :) Well done Yuri!

Here's my last review pass.

collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
collections/_article/dev-snapshot-godot-4-2-beta-1.md Outdated Show resolved Hide resolved
@YuriSizov @clayjohn
Update collections/_article/dev-snapshot-godot-4-2-beta-1.md
de2a5c4 
Co-authored-by: Clay John <claynjohn@gmail.com>
@YuriSizov YuriSizov merged commit 93e4933 into godotengine:master Oct 12, 2023
1 check passed
@YuriSizov
Copy link
Contributor Author

Thanks for reviews, everyone!

@YuriSizov YuriSizov deleted the release-4.2-beta1 branch October 12, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVeness JohnVeness JohnVeness left review comments

@raulsntos raulsntos raulsntos left review comments

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg left review comments

@clayjohn clayjohn clayjohn left review comments

@dalexeev dalexeev dalexeev left review comments

Assignees
No one assigned
Labels
topic:blog New blogposts and corrections topic:content Issues and PRs related to static content topic:releases Issues and PRs related to new engine releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YuriSizov @dalexeev @JohnVeness @raulsntos @akien-mga @bruvzg @clayjohn