Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStreamPlayer icon should be sharper #10768

Closed
PixelTim opened this issue Sep 17, 2024 · 4 comments
Closed

AudioStreamPlayer icon should be sharper #10768

PixelTim opened this issue Sep 17, 2024 · 4 comments

Comments

@PixelTim
Copy link

Describe the project you are working on

A game with many SFX.

Describe the problem or limitation you are having in your project

AudioStreamPlayer icon should be sharper (less colors) (like CollisionShape2D, Area2D, StaticBody2D, AnimationPlayer icons), the same applies to AudioStreamPlayer2D and AudioStreamPlayer3D icons.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Making icons pixel-perfect will probably make it look better.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

My version of icons:
GithubSoundIconsUpdateSuggestion

If this enhancement will not be used often, can it be worked around with a few lines of script?

Probably creating a plugin that changes editor icons to custom ones will work, but I'm not sure if this is possible.

Is there a reason why this should be core and not an add-on in the asset library?

This will make editor GUI look better

@Mickeon
Copy link

Mickeon commented Sep 17, 2024

Not sure this is feasible, due of the way these icons are imported from a SVG, but it may be doable to shift the vertices in a way that it would make them less blurry.

Loosely related to #10608

@tetrapod00
Copy link

I checked the SVG for AudioStreamPlayer and right now most of the verts and edges are not pixel aligned or even half-pixel aligned. So it could definitely be tweaked so that there's less visible antialiasing at small sizes.

@gongpha
Copy link

gongpha commented Sep 19, 2024

I'm not sure if #95763 has already solved this.

@Mickeon
Copy link

Mickeon commented Sep 20, 2024

I believe yes. Oh, how time flies, I completely forgot about it.

Closing, as this has been implemented on current master by godotengine/godot#95763. Thank you for the proposal.

@Mickeon Mickeon closed this as completed Sep 20, 2024
@Mickeon Mickeon added this to the 4.4 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants