Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement colored gradient on AudioStreamPlayer icons #10608

Open
vPumpking opened this issue Aug 30, 2024 · 5 comments
Open

Reimplement colored gradient on AudioStreamPlayer icons #10608

vPumpking opened this issue Aug 30, 2024 · 5 comments

Comments

@vPumpking
Copy link

vPumpking commented Aug 30, 2024

Describe the project you are working on

any game

Describe the problem or limitation you are having in your project

As a person with real bad eyes, the gradient on the previous version of the audiostreamplayer icon really helps me a lot in recognizing it.
I'm sure other people face the same problem. i suggest we do that for accessibility

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Implemement back the gradient on the new icon.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

AudioStreamPlayer_Gradient

If this enhancement will not be used often, can it be worked around with a few lines of script?

no

Is there a reason why this should be core and not an add-on in the asset library?

it's an icon

@AThousandShips
Copy link
Member

This was changed to implement:

Which improved usability from the old icons, to indicate type, implemented in:

How would you suggest making all the audio steam players visible, without making it confusing to tell the 2D, 3D, and non-positional ones apart

@vPumpking
Copy link
Author

yeah you're right, would be difficult

@Meorge
Copy link

Meorge commented Aug 30, 2024

I recall there being a discussion about adding some sort of shape cue to differentiate 2D and 3D nodes aside from their color. With an (admittedly very quick) search of the godot-proposals repository I didn't spot it, but I feel like it could be worth merging this discussion into that one, if it's still being considered.

@Calinou
Copy link
Member

Calinou commented Aug 31, 2024

I recall there being a discussion about adding some sort of shape cue to differentiate 2D and 3D nodes aside from their color. With an (admittedly very quick) search of the godot-proposals repository I didn't spot it, but I feel like it could be worth merging this discussion into that one, if it's still being considered.

You're thinking about #794 🙂

@Mickeon
Copy link

Mickeon commented Sep 2, 2024

I guess it could be an additional gradient overlaid on top. It would begin from pure white/blue/red on the left and transition to transparent.

image

I'm not even sure if it's possible to do this with SVGs (probably yes).
Alternatively the speaker could be coloured and the sound waves could keep the audio gradient, which achieves a similar effect but looks less... cool.

Unsure if reverting the icon a bit is very desired at the moment, though.

@Calinou Calinou changed the title Reimplement audiostreamplayer icon gradient Reimplement colored gradient on AudioStreamPlayer icons Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants