-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Godot 4.1 Support #198
Conversation
jokoho48
commented
Jul 12, 2023
•
edited by Calinou
Loading
edited by Calinou
- Update godot-cpp
- Fix Entry Point that changed within Godot 4.1
- Add compatibility_minimum to gdextension required for 4.1 support
- Bump version in plugin.cfg
- Upgrade demo project to 4.1
- Production edit: See Update plugin for Godot 4.2 due to GDExtension compatibility breakage #196.
- Update godot-cpp - Fix Entry Point that changed within Godot 4.1 - Add compatibility_minimum to gdextension required for 4.1 support - Bump version in plugin.cfg - Upgrade demo project to 4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the windows version in Checks, and successfully loaded the plugin, commited changes and pushed it to my repo.
(I don't familiar with rules so I just gonna choose "Approve" because I really want 4.1 to be supported, maybe it requires testing on all the platforms?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg I wrote a lot then forgot the review checkbox
Is this update compatible with Godot 4.2 as well as 4.1? |
It does not, at least here. breaks on |
Update: I frankenstein'd the latest godot-cpp into this PR, and it got past the build error. godot-cpp included is from 4.1 and is not compatible with 4.2.dev3. It now breaks on not finding libssl.la |
Ah nevermind - just read #183. I can now confirm the commit tab pops up and works for macos |
What's the state of this? Can this already be used? |
^ Echoing the above, would love to be able to use this plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was approved by @paddy-exe on the Godot Contributors Chat.
Note that a tagged release with this commit included still needs to be made, so that official downloads support Godot 4.1 and later. In the meantime, you can download the current stable release and replace the native library with this PR's artifacts, which I've reuploaded for future reference:
I briefly tested v3.0.1 of this plugin on Linux, using the .zip provided above, with Godot 4.1.2-rc1 and 4.2-dev6, and did not find any new issues. I did have this problem, but I first encountered that with v3.0.0. |
Using: Downloading and importing: Still gives me:
|
That's not an error. That message is displayed if you attempt to enable the plugin in Project Settings. With this plugin, you don't do that.
(I think that the Godot editor needs a fix for this situation. It's confusing to users.) |