Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Godot 4.1 Support #198

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add Godot 4.1 Support #198

merged 1 commit into from
Sep 22, 2023

Conversation

jokoho48
Copy link
Contributor

@jokoho48 jokoho48 commented Jul 12, 2023

  • Update godot-cpp
  • Fix Entry Point that changed within Godot 4.1
  • Add compatibility_minimum to gdextension required for 4.1 support
  • Bump version in plugin.cfg
  • Upgrade demo project to 4.1

- Update godot-cpp
- Fix Entry Point that changed within Godot 4.1
- Add compatibility_minimum to gdextension required for 4.1 support
- Bump version in plugin.cfg
- Upgrade demo project to 4.1
Copy link

@LSDog LSDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded the windows version in Checks, and successfully loaded the plugin, commited changes and pushed it to my repo.

(I don't familiar with rules so I just gonna choose "Approve" because I really want 4.1 to be supported, maybe it requires testing on all the platforms?)

Copy link

@LSDog LSDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg I wrote a lot then forgot the review checkbox

@Calinou Calinou requested a review from twaritwaikar July 27, 2023 22:17
@daveTheOldCoder
Copy link

Is this update compatible with Godot 4.2 as well as 4.1?
(At this time, the latest 4.2 is 4.2-dev3.)

@jason-oliveira
Copy link

Is this update compatible with Godot 4.2 as well as 4.1? (At this time, the latest 4.2 is 4.2-dev3.)

It does not, at least here. breaks on godot-git-plugin/src/gdlibrary.cpp:22:50: error: 'GDExtensionInterfaceGetProcAddress' does not name a type

@jason-oliveira
Copy link

Is this update compatible with Godot 4.2 as well as 4.1? (At this time, the latest 4.2 is 4.2-dev3.)

It does not, at least here. breaks on godot-git-plugin/src/gdlibrary.cpp:22:50: error: 'GDExtensionInterfaceGetProcAddress' does not name a type

Update: I frankenstein'd the latest godot-cpp into this PR, and it got past the build error. godot-cpp included is from 4.1 and is not compatible with 4.2.dev3.

It now breaks on not finding libssl.la

@paddy-exe paddy-exe mentioned this pull request Sep 6, 2023
@ezragoss
Copy link

ezragoss commented Sep 7, 2023

Just downloaded the macos universal artifact from Checks and opened the test project (as well as tried to import on a fresh project). Enabling the add on errors with

ERROR: Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'.

The check seems to have passed which is confusing. That file does indeed not exist in the artifact.

Ah nevermind - just read #183. I can now confirm the commit tab pops up and works for macos

@jasonlessenich
Copy link

What's the state of this? Can this already be used?

@Iseeicy
Copy link

Iseeicy commented Sep 22, 2023

^ Echoing the above, would love to be able to use this plugin

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was approved by @paddy-exe on the Godot Contributors Chat.

Note that a tagged release with this commit included still needs to be made, so that official downloads support Godot 4.1 and later. In the meantime, you can download the current stable release and replace the native library with this PR's artifacts, which I've reuploaded for future reference:

@Calinou Calinou merged commit 55b09bf into godotengine:master Sep 22, 2023
@jokoho48 jokoho48 deleted the gd4_1 branch September 22, 2023 19:52
@daveTheOldCoder
Copy link

daveTheOldCoder commented Sep 23, 2023

I briefly tested v3.0.1 of this plugin on Linux, using the .zip provided above, with Godot 4.1.2-rc1 and 4.2-dev6, and did not find any new issues.

I did have this problem, but I first encountered that with v3.0.0.

@heckert-gamedev
Copy link

heckert-gamedev commented Oct 13, 2023

Using:
Godot v4.1.2.stable - Ubuntu 20.04.5 LTS (Focal Fossa) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Ti Laptop GPU () - AMD Ryzen 5 5600H with Radeon Graphics (12 Threads)

Downloading and importing:
libgit_plugin.linux.x86_64.editor.so-c89b1f54a62707d96143ee336a3e0ee6b8ccb40e.zip

Still gives me:

  Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'.
  Failed loading resource: res://addons/godot-git-plugin/godot-git-plugin.gd. Make sure resources have been imported by opening the project in the editor at least once.

@daveTheOldCoder
Copy link

daveTheOldCoder commented Oct 13, 2023

Still gives me:
Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'.
Failed loading resource: res://addons/godot-git-plugin/godot-git-plugin.gd. Make sure resources have been imported by opening the project in the editor at least once.

That's not an error. That message is displayed if you attempt to enable the plugin in Project Settings. With this plugin, you don't do that.

Note: you do NOT need to manually enable the plugin in the Project > Project Settings > Plugins tab. In fact, you can't; that tab is for script-based plugins, GDExtension plugins, like this one, will be loaded automatically.

Wiki/Installation

(I think that the Godot editor needs a fix for this situation. It's confusing to users.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants