Address issue #172, to use public key path if present in preference to using password. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I don't know how to move these checks along. What are these checks how do you run them, and how do you get a review approved? |
|
Closing and opening to re-trigger checks |
Fix ubuntu version to match godot-cpp
Update build.yml
twaritwaikar
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix simply changes the use of SSH credentials to be conditional based on the presence of SSH credentials in the Credentials object.
This lets the user specify the presence of SSH credentials if that is the desired method, or the password if that is the desired method. I tested against a repository that used SSH credentials and one that used a password.
The third method was a bit of a mystery to me, so I didn't test that option. I also do not have a Windows or Mac environment to test this in (only tested in Linux), but with only this small change it is hard to imagine what could be different.