Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return types in platformer's pause_menu.gd #910

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Add missing return types in platformer's pause_menu.gd #910

merged 1 commit into from
Apr 16, 2023

Conversation

Araraura
Copy link
Contributor

No description provided.

aaronfranke
aaronfranke approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the reason these were missing before is that in Godot 3.x the type hints did not make a performance difference so we left them out of the official demos. For Godot 4.x, it's good to include them.

@aaronfranke aaronfranke merged commit 0d02b2f into godotengine:master Apr 16, 2023
@Calinou
Copy link
Member

Calinou commented Apr 16, 2023

Note that the reason these were missing before is that in Godot 3.x the type hints did not make a performance difference so we left them out of the official demos. For Godot 4.x, it's good to include them.

For future reference, see #868.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Araraura @Calinou @aaronfranke