Add a variable rate shading demo #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
add-variable-rate-shading-demo
branch
from
c5413d9
to
57f3e70
Compare
|
Will be testing this today. |
fire
reviewed
Mar 10, 2023
| get_viewport().use_xr = true | ||
| xr_camera.current = true | ||
|
|
||
| # Reposition our origin point to work around an engine bug. |
There was a problem hiding this comment.
I commented out the line and the bug occurred in 4.0.stable, so yes.
There was a problem hiding this comment.
Hmm, weird, I was under the impression that was fixed. I might need to have another look at that :)
fire
reviewed
Mar 10, 2023
| texture_rect.texture = texture | ||
| texture_rect.visible = true | ||
| elif vrs_mode == Viewport.VRS_XR: | ||
| # Doesn't seem to be supported yet. This should be exposed in a future engine version. |
There was a problem hiding this comment.
To my knowledge, yes.
There was a problem hiding this comment.
I think this is just a matter of binding get_vrs_texture in XRInterface so we have access to it.
BastiaanOlij
approved these changes
Mar 30, 2023
This project showcases how to use variable rate shading (VRS) in 3D to improve performance. Performance metrics are also displayed to evaluate potential performance gains.
Calinou
force-pushed
the
add-variable-rate-shading-demo
branch
from
57f3e70
to
fc65fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project showcases how to use variable rate shading (VRS) in 3D to improve performance.
Performance metrics are also displayed to evaluate potential performance gains.
Once this PR is merged, we can link to the demo in the documentation 🙂
Preview