Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory usage to the Voxel demo #497

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

aaronfranke
Copy link
Member

I recently added this to the TPS demo's debug menu, so I figured I would add it to the Voxel demo too.

@aaronfranke aaronfranke merged commit 8d9d58f into godotengine:master Jul 9, 2020
@aaronfranke aaronfranke deleted the voxel-memory branch July 9, 2020 20:57
@volzhs
Copy link
Contributor

volzhs commented Jul 9, 2020

isn't it better to use String.humanize_size(bytes)? just my 2 cents.

@aaronfranke
Copy link
Member Author

humanize_size always outputs 4 digits, for this demo I think it's better to only display increments of one MiB.

But thanks for bringing that up, and I will likely use that in the future.

@volzhs
Copy link
Contributor

volzhs commented Jul 9, 2020

Oh i see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants