Modify shader example to show using build in includes #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
demo_buildin_includes
branch
from
be084c3 to
574ee8b
Compare
BastiaanOlij
force-pushed
the
demo_buildin_includes
branch
from
574ee8b to
1ce1aa2
Compare
BastiaanOlij
force-pushed
the
demo_buildin_includes
branch
from
1ce1aa2 to
aa2133d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The upstream PR this showcases functionality for was merged. |
AThousandShips
approved these changes
Jul 10, 2025
| @@ -115,7 +134,8 @@ func _render_callback(p_effect_callback_type: EffectCallbackType, p_render_data: | |||
| # Get our render scene buffers object, this gives us access to our render buffers. | |||
| # Note that implementation differs per renderer hence the need for the cast. | |||
| var render_scene_buffers := p_render_data.get_render_scene_buffers() | |||
| if render_scene_buffers: | |||
| var scene_data := p_render_data.get_render_scene_data() | |||
| if render_scene_buffers && scene_data: | |||
There was a problem hiding this comment.
Suggested change
| if render_scene_buffers && scene_data: | |
| if render_scene_buffers and scene_data: |
| depth_uniform.add_id(depth_image) | ||
| var uniform_set := UniformSetCacheRD.get_cache(shader, 0, [scene_data_uniform, color_uniform, depth_uniform]) | ||
|
|
||
| # Set our view |
There was a problem hiding this comment.
Suggested change
| # Set our view | |
| # Set our view. |
| # Loop through views just in case we're doing stereo rendering. No extra cost if this is mono. | ||
| var view_count: int = render_scene_buffers.get_view_count() | ||
| for view in view_count: | ||
| # Get the RID for our scene data buffer |
There was a problem hiding this comment.
Suggested change
| # Get the RID for our scene data buffer | |
| # Get the RID for our scene data buffer. |
| @@ -137,18 +157,43 @@ func _render_callback(p_effect_callback_type: EffectCallbackType, p_render_data: | |||
| 0.0, | |||
| ]) | |||
|
|
|||
| # Make sure we have a sampler | |||
There was a problem hiding this comment.
Suggested change
| # Make sure we have a sampler | |
| # Make sure we have a sampler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement of the post_shader demo adds in logic that brings in build in defines for our scene data uniform, so we have access to projection matrices and other information.
Requires godotengine/godot#94193