Skip to content

WebSocket Multiplayer Demo Mini-"Bug" #652

Open
@Av3r3tt

Description

@Av3r3tt

Which demo project is affected:

WebSocket Multiplayer Demo
https://godotengine.org/asset-library/asset/540

OS/device including version:

Irrelevant - it's an easy fix

Issue description:

In Script main.gd in this project, the constant for the Protocol Name is defined in line 04 thus:
const PROTO_NAME = "ludus"

This is properly used in the code later down, but not in line 73. where instead the content of PROTO_NAME is typed out again. So, Line 73 should read:
host.listen(DEF_PORT, PoolStringArray([PROTO_NAME]), true)
instead of
host.listen(DEF_PORT, PoolStringArray(["ludus"]), true)

The reason why this matters is that when users presume the code to be fine they might just change the constant at the top (which I did) only to find that if you rename it the connections no longer work for apparently no reason.

That is all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions