Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket Multiplayer Demo Mini-"Bug" #652

Open
Av3r3tt opened this issue Oct 13, 2021 · 0 comments
Open

WebSocket Multiplayer Demo Mini-"Bug" #652

Av3r3tt opened this issue Oct 13, 2021 · 0 comments
Labels

Comments

@Av3r3tt
Copy link

Av3r3tt commented Oct 13, 2021

Which demo project is affected:

WebSocket Multiplayer Demo
https://godotengine.org/asset-library/asset/540

OS/device including version:

Irrelevant - it's an easy fix

Issue description:

In Script main.gd in this project, the constant for the Protocol Name is defined in line 04 thus:
const PROTO_NAME = "ludus"

This is properly used in the code later down, but not in line 73. where instead the content of PROTO_NAME is typed out again. So, Line 73 should read:
host.listen(DEF_PORT, PoolStringArray([PROTO_NAME]), true)
instead of
host.listen(DEF_PORT, PoolStringArray(["ludus"]), true)

The reason why this matters is that when users presume the code to be fine they might just change the constant at the top (which I did) only to find that if you rename it the connections no longer work for apparently no reason.

That is all.

@Av3r3tt Av3r3tt added the bug label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant