Fix TypedDictionary binding generation #1763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
TypedDictionary
bindings fail to generate correctly.This issue has not been apparent so far because Godot has not exposed any API using
TypedDictionary
, but it makes CI checks fail on PRs such as godotengine/godot#104096 which do so.This PR fixes the bindgen with two small tweaks:
TypedDictionary<KeyType, ValueType>
For convenience, here is an
extension_api.json
generated from the above PR. The issue is related to thetypeddictionary::
entries.extension_api.json
Fixes godotengine/godot#100137