Correct type for char16 and char32 meta#1554
Merged
Merged
Conversation
raulsntos
added
enhancement
akien-mga
reviewed
Aug 20, 2024
Comment on lines
2724
to
2725
| elif meta in type_conversion: | ||
| return type_conversion[type_name] |
Member
There was a problem hiding this comment.
Looking at the type_conversion above and
static const char *argmeta[13] = { "none", "int8", "int16", "int32", "int64", "uint8", "uint16", "uint32", "uint64", "float", "double", "char16", "char32" };
does this mean that float meta in the above array also gets converted to double?
Member
Author
There was a problem hiding this comment.
Yes, that's unfortunate. I think this elif can be removed since you are never going to get int or Nil as metadata, and if you get float then it means float (not double).
- Edit: Opened Avoid hardcoded type conversion for metadata #1555
akien-mga
approved these changes
Aug 20, 2024
dsnopek
approved these changes
Aug 22, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good to me :-)
Collaborator
|
Ack, needs a rebase because I merged PR #1555 first |
raulsntos
force-pushed
the
char-metadata
branch
from
a1e1418 to
9a89d22
Compare
Collaborator
|
Cherry-picked for 4.3 in PR #1569 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
char16_tandchar32_tgodot#95840.