Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust clang version checking to account for other non-vanilla clangs #1380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust clang version checking to account for other non-vanilla clangs #1380

wants to merge 1 commit into from
+5 −4

Commits on Feb 9, 2024

  1. Adjust clang version checking to account for other non-vanilla clangs 

    We can no longer make the assumption that all non-vanilla clang versions
are Apple's clang or that all other non vanilla clangs will work with
the given arguments. There are times where additional tools might use non vanilla clang
and the presumed arguments here will break compilation on those
platforms.

We might want to consider adding tooling-specific optimazation functions
long term to fetch desired optimizations on a platform basis.
    @Eoin-ONeill-Yokai
    Eoin-ONeill-Yokai committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    368f671 View commit details
    Browse the repository at this point in the history