Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AABB.encloses failing on shared upper bound #1360

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix AABB.encloses failing on shared upper bound #1360

merged 1 commit into from
Jan 19, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug This has been identified as a bug cherrypick:4.2 labels Jan 15, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 15, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 15, 2024 12:40
dsnopek
dsnopek approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@dsnopek dsnopek merged commit 480a0f8 into godotengine:master Jan 19, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jan 19, 2024

Thanks!

@AThousandShips AThousandShips deleted the aabb_fix branch January 19, 2024 13:31
@AThousandShips
Copy link
Member Author

Thank you!

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 22, 2024

Cherry-picking to 4.2 in #1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @dsnopek @akien-mga