Skip to content

Make BUILD_NAME globally configurable #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Mar 6, 2021

Makes it easier to distinguish between official and custom builds by allowing developers to customize BUILD_NAME env var.

I can make it to default to custom_build over official if you like. Of course, nothing prevents someone to use official name, but this will decrease the likelihood of someone compiling the editor and export templates as official, otherwise the only way to distinguish such builds is by using checksums.

Also note that BUILD_NAME can be fetched at run-time via script with Engine.get_version_info().

@akien-mga
Copy link
Member

Looks good! Yeah I think it would make sense to make it default to custom_build, I can set official in my own config.sh.

@Xrayez Xrayez force-pushed the config-build-name branch from c0b7d49 to f40716e Compare March 6, 2021 15:16
@Xrayez
Copy link
Contributor Author

Xrayez commented Mar 6, 2021

Changed to custom_build by default.

@akien-mga akien-mga merged commit 2e2fa65 into godotengine:master Mar 6, 2021
@akien-mga
Copy link
Member

Thanks!

@Xrayez Xrayez deleted the config-build-name branch March 6, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants