Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - add installation folder #132

Closed
BastiaanOlij opened this issue Mar 2, 2018 · 8 comments
Closed

Proposal - add installation folder #132

BastiaanOlij opened this issue Mar 2, 2018 · 8 comments

Comments

@BastiaanOlij
Copy link

Right now when an asset is downloaded the files are placed directly in the root of your project folder. You need to include the folder structure in your asset and files such as the readme and license files that often reside in the root of a github project end up in the root of your project folder. This can get very messy if you use multiple assets in your project.

It would be nice if it was possible to specify a folder into which the asset should be placed. This can still be the root of the project for assets such as demos but for other projects it could be something like "addon/myaddon" and the contents of the git repository gets placed in that.

@punto-
Copy link

punto- commented Mar 2, 2018 via email

@vnen
Copy link
Member

vnen commented Mar 2, 2018

Is it possible to only download a part of the repository?

Yes, the interface in Godot allows you to select the files to download. All files in the root are unselected by default (this avoids downloading readme, license, etc.).


This is probably a thing for the main engine repo though. Also, see godotengine/godot#6023

@BastiaanOlij
Copy link
Author

@punto- as vnen said, yes you can already select but I think it is actually important to have the readme and license downloaded, but placed in the add on folder

@vnen a I didn't see that though I do believe that the default installation location should be set in the asset library itself especially because paths inside resources and scenes will not change along.

@punto-
Copy link

punto- commented Mar 2, 2018 via email

@YeldhamDev
Copy link
Member

YeldhamDev commented Mar 14, 2018

@vnen

Yes, the interface in Godot allows you to select the files to download. All files in the root are unselected by default (this avoids downloading readme, license, etc.).

But that's not what happens at all. All files are downloaded and selected by default.

@BastiaanOlij
Copy link
Author

@punto- I actually like the idea of being able to select a subfolder as the root of what is being downloaded. That would also allow me to have a single repository instead of the two repositories I maintain right now for each asset.

@YeldhamDev that can be fixed, but I'm not a big fan of that as a solution either.

@bitwes
Copy link

bitwes commented Mar 15, 2018

I've been struggling with this with Gut for awhile now. I think the default checkmarks in the engine would be a good short putt. One thing I'm concerned about is that if I have a LICENSE.md in the root of my project, and someone doesn't uncheck it, then now their project has my same LICENSE.md. Same goes for README.md and CHANGES.md and any other files, but the LICENSE.md probably has the worst possible repercussions.

@Calinou
Copy link
Member

Calinou commented Mar 20, 2023

Closing in favor of godotengine/godot-proposals#554.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants