Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing godot command line link #44

Merged
merged 1 commit into from
May 8, 2024

Conversation

jsjtxietian
Copy link
Contributor

Hi thanks for the awesome work!

When I'm reading the book I noticed that there is a link missing here:

image

This pr adds the missing link.

Also the issue godotengine/godot#66231 seems be fixed, I guess it can be updated in the book ? I tried with my windows machine it seems work fine

@Bromeon
Copy link
Member

Bromeon commented May 7, 2024

Thanks a lot! Oh you're right, that part is outdated. Do you want to include it in your changes?

Something like "Since Godot 4.2, it is possible to hot-reload extensions. This means you can recompile your Rust code and Godot will pick up changes, without needing to restart the editor."

@jsjtxietian
Copy link
Contributor Author

Do you want to include it in your changes?

Yes, I'm happy to include it , probably sometime tomorrow.

@Bromeon Bromeon merged commit 88d84a4 into godot-rust:master May 8, 2024
4 checks passed
@Bromeon
Copy link
Member

Bromeon commented May 8, 2024

Thanks for your contribution!

@jsjtxietian jsjtxietian deleted the fix-command-link branch May 9, 2024 03:15
@jsjtxietian
Copy link
Contributor Author

Thanks! Looking forward to contributing more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants