Remove disruptive regex for URL validation#191
Open
Fra146 wants to merge 1 commit into
Open
Conversation
Author
|
After more analysis it would seem that this regex is executed for each entry of the social media in the site footer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provided changes remove a very destructive regex.
I will provide the lighthouse reports for the before and after
It would seem that this causes a recursion when checking for the validity of social media links. I'm unsure of when this happens exactly (on a blank site nothing happens) but on my full site it does slow the page down by 14 seconds.