Skip to content

Commit f6b7397

Browse files
authored
Revert "Compile libcxx and libcxxabi (flutter#190)" (flutter#191)
This reverts commit 98cd682.
1 parent 98cd682 commit f6b7397

File tree

4 files changed

+9
-149
lines changed

4 files changed

+9
-149
lines changed

build/config/BUILDCONFIG.gn

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -632,31 +632,6 @@ if (custom_toolchain != "") {
632632
}
633633
}
634634

635-
# Sets default dependencies for executable and shared_library targets.
636-
#
637-
# Variables
638-
# no_default_deps: If true, no standard dependencies will be added.
639-
if (is_android) {
640-
foreach(_target_type,
641-
[
642-
"executable",
643-
"loadable_module",
644-
"shared_library",
645-
]) {
646-
template(_target_type) {
647-
target(_target_type, target_name) {
648-
forward_variables_from(invoker, "*", [ "no_default_deps" ])
649-
if (!defined(deps)) {
650-
deps = []
651-
}
652-
if (!defined(invoker.no_default_deps) || !invoker.no_default_deps) {
653-
deps += [ "//third_party/libcxx" ]
654-
}
655-
}
656-
}
657-
}
658-
}
659-
660635
# ==============================================================================
661636
# COMPONENT SETUP
662637
# ==============================================================================

build/config/compiler/BUILD.gn

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,10 @@ config("runtime_library") {
520520
# strange errors. The include ordering here is important; change with
521521
# caution.
522522
cflags += [
523+
"-isystem" + rebase_path("$android_libcpp_root/include", root_build_dir),
524+
"-isystem" + rebase_path(
525+
"$android_ndk_root/sources/cxx-stl/llvm-libc++abi/include",
526+
root_build_dir),
523527
"-isystem" +
524528
rebase_path("$android_ndk_root/sources/android/support/include",
525529
root_build_dir),
@@ -529,14 +533,13 @@ config("runtime_library") {
529533
"-D__ANDROID_API__=$android_api_level",
530534
]
531535

532-
include_dirs = [
533-
"//third_party/libcxx/include",
534-
"//third_party/libcxxabi/include",
535-
]
536-
537-
# libunwind and libandroid_support also live in $android_libcpp_root.
538536
lib_dirs += [ "$android_libcpp_root/libs/$android_app_abi" ]
539537

538+
libs += [
539+
"$android_libcpp_library",
540+
"c++abi",
541+
]
542+
540543
if (android_api_level < 21) {
541544
libs += [ "android_support" ]
542545
}

build/secondary/third_party/libcxx/BUILD.gn

Lines changed: 0 additions & 63 deletions
This file was deleted.

build/secondary/third_party/libcxxabi/BUILD.gn

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)