Compile libcxx and libcxxabi #190
Conversation
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Sorry, wrongly approved earlier.
goderbauer
force-pushed
the
compilelibcxx
branch
from
74fd965 to
1af5581
Compare
build/config/BUILDCONFIG.gn
Outdated
| # | ||
| # Variables | ||
| # no_default_deps: If true, no standard dependencies will be added. | ||
| foreach(_target_type, |
There was a problem hiding this comment.
This makes adding implicit dependencies to libcxx obsolete (i.e. this line can now be removed: https://github.com/flutter/engine/pull/6886/files#diff-633f71f2d7c61833a0d6668534227b21R63).
There was a problem hiding this comment.
This needs to be on Android only for now.
There was a problem hiding this comment.
I had the is_android check down below, but to make it more clear I pulled it up to the top level.
There was a problem hiding this comment.
Derp. Didn't notice it down below. Yeah, moving it to the top level with a comment saying why this is android only would be great.
build/config/BUILDCONFIG.gn
Outdated
| # | ||
| # Variables | ||
| # no_default_deps: If true, no standard dependencies will be added. | ||
| foreach(_target_type, |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I could not build this in debug mode on Android.
| "$android_libcpp_library", | ||
| "c++abi", | ||
| include_dirs = [ | ||
| "//third_party/libcxx/include", |
There was a problem hiding this comment.
Also, having these in the public configs should make this include point moot.
There was a problem hiding this comment.
The compiler still needs these to resolve libcxx symbols in source_set targets. Those targets currently do not get an implicitly added dependency to libcxx (same thing in chrome: https://cs.chromium.org/chromium/src/build/config/posix/BUILD.gn?type=cs&g=0&l=47).
build/config/BUILDCONFIG.gn
Outdated
| # | ||
| # Variables | ||
| # no_default_deps: If true, no standard dependencies will be added. | ||
| foreach(_target_type, |
There was a problem hiding this comment.
This needs to be on Android only for now.
goderbauer
force-pushed
the
compilelibcxx
branch
from
4c5287d to
0424df3
Compare
This reverts commit 98cd682.
This reverts commit f6b7397.
2 participants
No description provided.