Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gasket contribution docs #96

Merged
merged 4 commits into from
Nov 5, 2019
Merged

gasket contribution docs #96

merged 4 commits into from
Nov 5, 2019

Conversation

cfellin1
Copy link
Contributor

Summary

Many of these docs are adapted from corresponding docs for warehouse and ekke. The two that are original are:

  • RELEASES
  • GOVERNANCE

So these are probably the two that demand the most attention. I could particularly benefit from some more clarity on whether we are bumping versions for all of Gasket or just individual packages with each change.

Changelog

  • Add contribution guidelines

Test Plan

Thoughtful copy editing? :P

@cfellin1 cfellin1 changed the title gasket contribution docs WIP: gasket contribution docs Oct 28, 2019
@cfellin1 cfellin1 changed the title WIP: gasket contribution docs gasket contribution docs Oct 28, 2019
Copy link
Contributor

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid start – had some comments on GOVERNANCE and would also like to see the TODOs addressed before merging.

GOVERNANCE.md Outdated
### Maintainer

Maintainers have commit permissions. They are responsible for creating release
commits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid start, but there are a few questions I would expect folks to have after they finish reading it:

  • How do I become a Maintainer?
  • Do contributors have rights to moderate issues?
  • Who are the current Maintainers?
  • Where is the roadmap for the project?

@cfellin1
Copy link
Contributor Author

cfellin1 commented Nov 1, 2019

@indexzero RE the TODOs, do I have the go-ahead to create a #gasket channel on GoDaddy open source Slack?

@indexzero
Copy link
Contributor

@cfellin1 sure!

@indexzero indexzero merged commit 5c54030 into master Nov 5, 2019
@indexzero indexzero deleted the guidelines branch November 5, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants