Allow presets to define metadata #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaagie
requested changes
Oct 4, 2019
| @@ -27,7 +27,12 @@ const mockPluginInfo = { | |||
|
|
|||
| const mockPresetInfo = { | |||
| name: '@gasket/mock-preset', | |||
| module: {}, | |||
| metqadataKey: 'oldMetadataValue', | |||
There was a problem hiding this comment.
should this be metqadataKey
Suggested change
| metqadataKey: 'oldMetadataValue', | |
| metadataKey: 'oldMetadataValue', |
| @@ -125,5 +130,9 @@ describe('Metadata plugin', function () { | |||
| assume(gasket.metadata.plugins[0]).property('modified', true); | |||
| }); | |||
|
|
|||
| it('loads preset metadata and overrides it if collision found', function () { | |||
There was a problem hiding this comment.
Could we extend this testcase to both assert the before and after? Based on the typo above, we don't really know whether data changed or not.
kinetifex
approved these changes
Oct 7, 2019
Swaagie
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow presets to define metadata since they can't hook into lifecycles.
Changelog
Entry added.
Test Plan
Tests added.