Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dependencies during create #73

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Check dependencies during create #73

merged 2 commits into from
Oct 2, 2019

Conversation

DanielSanudo
Copy link
Contributor

Summary

Exposing .has on the pkg object in the create lifecycle in order to be able to check if a dependency was added or not.

Changelog

Entry included.

Test Plan

Unit tests included for the different cases.

@DanielSanudo DanielSanudo merged commit b2bd9e1 into master Oct 2, 2019
@DanielSanudo DanielSanudo deleted the GX-18131 branch October 2, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinetifex kinetifex kinetifex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSanudo @kinetifex