Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple --preset-path with --presets #70

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Conversation

DanielSanudo
Copy link
Contributor

Summary

--preset-path and --presets were exclusive. There is no reason for this, so we should allow those flags to be used together.

Changelog

Entry added.

Test Plan

Unit tests added for the new different cases.

Copy link
Contributor

@kinetifex kinetifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇Nice work

@DanielSanudo DanielSanudo merged commit 9d340b4 into master Sep 30, 2019
@DanielSanudo DanielSanudo deleted the GX-17955 branch September 30, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants