Do not assume APM exists #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since `gasket.apm` is not initialized for the `local` command, fix its type - Do not inject transaction renaming middleware when `gasket.apm` is undefined
|
| Name | Status | Previous | Current |
|---|---|---|---|
ip |
2.0.0 | 2.0.1 | |
jsdoc-parse |
6.1.0 | 6.2.1 | |
lodash.pick |
4.4.0 | - | |
lodash.set |
4.3.2 | - | |
nock |
13.2.4 | 13.5.4 | |
search-insights |
- | 2.13.0 | |
wait-on |
- | 7.0.1 |
kbader-godaddy
approved these changes
Mar 12, 2024
rxmarbles
approved these changes
Mar 12, 2024
agerard-godaddy
pushed a commit
that referenced
this pull request
Apr 17, 2024
(cherry picked from commit b70ed25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gasket.apmis not initialized for thelocalcommand, fix its typegasket.apmis undefinednpm audit fixSummary
Customer reported that they got a
TypeErrordue to the transaction renaming middleware of@gasket/plugin-elastic-apm. Support thread for context.Changelog
Test Plan
Added unit test