[feat] include gasket-plugin-engine in monorepo #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfellin1 thanks for this. Could you please amend your commits with this? If you're not familiar with amending commits you can find the information in the documentation from Github. The reasoning for this ask is to attempt to properly attribute the original authors of the work as it enters the mono-repo for the final open source release. |
Co-authored-by: Jacob Page <jpage@godaddy.com>
Co-authored-by: Jacob Page <jpage@godaddy.com>
Co-authored-by: Jacob Page <jpage@godaddy.com>
Co-authored-by: Jacob Page <jpage@godaddy.com>
Co-authored-by: Jacob Page <jpage@godaddy.com>
Co-authored-by: Jacob Page <jpage@godaddy.com>
indexzero
approved these changes
Jun 26, 2019
DullReferenceException
suggested changes
Jun 27, 2019
| @@ -0,0 +1,2 @@ | |||
| @gasket:registry=https://artifactory.secureserver.net/artifactory/api/npm/npm-gasket-core-local/ | |||
There was a problem hiding this comment.
We shouldn't be using artifactory for the public repo.
DullReferenceException
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.