Fix swagger fastify test #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Downgrade fastify to version compatible with `@fastify/swagger@6` - Commit npm audit changes - Remove unnecessary babel compilation
agerard-godaddy
approved these changes
Feb 6, 2023
mmason2-godaddy
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fastify/swagger@6Summary
The CI process runs
npm audit fix; this is causingfastifyto be upgraded and unit tests to fail. It looks like the tests for@gasket/plugin-swaggerwere only working because by happy coincidence thefastify@4version worked with@fastify/swagger@6even though@fastify/swagger@6officially only supportsfastify@3.Since
@gasket/plugin-fastifyis only on version 3 anyway, this downgrades to the supported version of fastify and avoids the unsupervised version bump from breaking the tests.Changelog
None necessary; just fixes unit tests.
Test Plan
Ensure unit tests pass.