Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger fastify test #548

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix swagger fastify test #548

merged 1 commit into from
Feb 7, 2023

Conversation

jpage-godaddy
Copy link
Contributor

  • Downgrade fastify to version compatible with @fastify/swagger@6
  • Commit npm audit changes
  • Remove unnecessary babel compilation

Summary

The CI process runs npm audit fix; this is causing fastify to be upgraded and unit tests to fail. It looks like the tests for @gasket/plugin-swagger were only working because by happy coincidence the fastify@4 version worked with @fastify/swagger@6 even though @fastify/swagger@6 officially only supports fastify@3.

Since @gasket/plugin-fastify is only on version 3 anyway, this downgrades to the supported version of fastify and avoids the unsupervised version bump from breaking the tests.

Changelog

None necessary; just fixes unit tests.

Test Plan

Ensure unit tests pass.

- Downgrade fastify to version compatible with `@fastify/swagger@6`
- Commit npm audit changes
- Remove unnecessary babel compilation
@agerard-godaddy agerard-godaddy merged commit 4ba76c6 into main Feb 7, 2023
@agerard-godaddy agerard-godaddy deleted the fix-swagger-fastify branch February 7, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants