Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin dependencies #497

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Plugin dependencies #497

merged 3 commits into from
Dec 19, 2022

Conversation

jpage-godaddy
Copy link
Contributor

Summary

Add the dependencies property to the Plugin type so that plugin authors using TypeScript don't get a type error when populating dependencies.

Changelog

Added

Test Plan

Added TypeScript "test" to confirm the dependencies array is allowed by the compiler.

@jpage-godaddy jpage-godaddy requested a review from a team as a code owner December 16, 2022 20:37
@kawikabader kawikabader merged commit d522a59 into main Dec 19, 2022
@kawikabader kawikabader deleted the plugin-dependencies branch December 19, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants