Allowing plugins and presets to be defined with one letter #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaagie
approved these changes
Aug 13, 2019
kinetifex
approved these changes
Aug 13, 2019
| @@ -15,7 +15,7 @@ class PackageIdentifier { | |||
| this.suffix = suffix; | |||
|
|
|||
| this.reShortName = new RegExp(`@gasket\\/([\\w-]+)${suffix}`); | |||
| this.reName = /^(.[\w/-]+)@?(.*)/; | |||
| this.reName = /^(.?[\w/-]+)@?(.*)/; | |||
There was a problem hiding this comment.
Suggested change
| this.reName = /^(.?[\w/-]+)@?(.*)/; | |
| this.reName = /^(@?[\w/-]+)@?(.*)/; |
That . was probably to capture '@' in scoped packaged. Making it optional like you did, but only looking for '@' will be another improvement.
There was a problem hiding this comment.
Couldn't figure out what that was doing, this makes sense, thanks for restoring my sanity in the process. 😁 Didn't feel like a major issue though, hence accepted
|
@DanielSanudo Also fill out the PR summary for bookkeeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated regex
@gasket/resolvein order to support plugins defined with one letter name.Changelog
Test Plan