Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CircleCI config. #4

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Setup CircleCI config. #4

merged 3 commits into from
Jun 14, 2019

Conversation

indexzero
Copy link
Contributor

@indexzero indexzero commented Jun 14, 2019 •
edited
Loading

Summary

Get CircleCI running

  • Update config
  • Configure jobs in such a way as they pass.

@msluther
Copy link
Contributor

Do we need to not do this so that circleci can install things? do we just need the scope one for publishing? https://github.com/godaddy/gasket/blob/master/.npmrc#L1

msluther
msluther approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@msluther msluther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay
Yay it worked!

@indexzero
Copy link
Contributor Author

@indexzero indexzero merged commit 0dc8ca0 into master Jun 14, 2019
@indexzero indexzero deleted the circleci branch June 14, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msluther msluther msluther approved these changes

@3rd-Eden 3rd-Eden Awaiting requested review from 3rd-Eden

@Swaagie Swaagie Awaiting requested review from Swaagie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indexzero @msluther