Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GASKET_ENV with process exposure #387

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Support GASKET_ENV with process exposure #387

merged 5 commits into from
Jun 30, 2022

Conversation

agerard-godaddy
Copy link
Contributor

Summary

For situations where an app needs to known the gasket CLI settings without access to the actually GasketEngine instance. Also introduces the distinct GASKET_ENV var, which will still fallback to NODE_ENV if neither it nor --env flag are set.

Changelog

@gasket/cli

  • Support for GASKET_ENV with fallback to NODE_ENV
  • expose gasket settings on process.env

@gasket/plugin-command

  • Support for GASKET_ENV with fallback to NODE_ENV

@gasket/plugin-start

  • Support for GASKET_ENV with fallback to NODE_ENV

Test Plan

  • Updated unit tests and locally testing in an app

@agerard-godaddy agerard-godaddy changed the title Gasket env Support GASKET_ENV with process exposure Jun 30, 2022
@agerard-godaddy agerard-godaddy merged commit 89d9412 into main Jun 30, 2022
@agerard-godaddy agerard-godaddy deleted the gasket-env branch June 30, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants