Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure clean builds before publishing #338

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Ensure clean builds before publishing #338

merged 2 commits into from
Feb 18, 2022

Conversation

kinetifex
Copy link
Contributor

Summary

We've occasionally had packages published with legacy build artifacts. This ensures the build dir is cleaned each time.

Changelog

  • delete build dirs before start

Test Plan

  • Validated build contents of modified packages.

@kinetifex kinetifex requested review from Swaagie and a team as code owners February 18, 2022 20:59
@kinetifex kinetifex merged commit 335af2c into main Feb 18, 2022
@kinetifex kinetifex deleted the clean-build branch February 18, 2022 21:24
@SNYKabbott SNYKabbott mentioned this pull request Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawikabader kawikabader kawikabader approved these changes

@rmarkins-godaddy rmarkins-godaddy rmarkins-godaddy approved these changes

@jpage-godaddy jpage-godaddy jpage-godaddy approved these changes

@rxmarbles rxmarbles Awaiting requested review from rxmarbles

@Swaagie Swaagie Awaiting requested review from Swaagie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinetifex @kawikabader @rmarkins-godaddy @jpage-godaddy