Skip to content

Conversation

@kinetifex
Copy link
Contributor

Summary

Lazying require webpack fixes the error with creating new apps with more recent versions of Next.js

> gasket create basic-next-app -p @gasket/preset-nextjs
Error: Cannot find module 'webpack'

This PR also defers other requires for init-related dependencies.

Changelog

@gasket/plugin-webpack

  • Lazy require webpack dependencies

Test Plan

  • Locally tested with create command
gasket create <APP_NAME> -p @gasket/preset-nextjs --plugins @gasket/plugin-webpack@file:/<PATH_TO>/godaddy/gasket/packages/gasket-plugin-webpack

@kawikabader
Copy link
Contributor

👏🏻

@kinetifex kinetifex merged commit f56acbc into master Nov 29, 2021
@kinetifex kinetifex deleted the SYNTH-550 branch November 29, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants