Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GasketData with Intl packages #223

Merged
merged 12 commits into from
Dec 10, 2020
Merged

Use GasketData with Intl packages #223

merged 12 commits into from
Dec 10, 2020

Conversation

kinetifex
Copy link
Contributor

@kinetifex kinetifex commented Dec 9, 2020 •
edited
Loading

Summary

This PR updates the intl packages to utilize @gasket/data (#192) as well as
provides req methods for handled locales on servers (#193).

Changelog

@gasket/helper-intl

  • Centralize server data loading util method (serverLoadData)
  • Centralize locale path statuses

@gasket/react-intl

  • Use helper serverLoadData
  • Use @gasket/data for SSR intl content
  • Updates for defaultPath property name

@gasket/plugin-intl

  • Updates for defaultPath property name
  • Fix manifest paths to include base path
  • Add req methods for loading/selecting locales messages with gasketData

@gasket/plugin-nextjs

  • Generate new apps with gasketData script injecting to _document.js

Test Plan

  • Local testing in dummy app
  • Updated and expanded unit tests

This was linked to issues Dec 9, 2020
Update intl v6 to use @gasket/data #192
Closed
Load locales to gasketData response #193
Closed
@kinetifex kinetifex changed the base branch from master to canary December 9, 2020 23:16
@kinetifex kinetifex merged commit 659a020 into canary Dec 10, 2020
@kinetifex kinetifex deleted the intl-fixup branch December 10, 2020 22:19
kawikabader added a commit that referenced this pull request Dec 12, 2020
@kawikabader
Merge branch 'canary' into remove-fallbacks
316aee4 
* canary:
  Use GasketData with Intl packages (#223)
  v6.0.0-canary.7
  [doc] changelog
  Rename gasket/intl to gasket/react-intl (#222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgessa23 burgessa23 burgessa23 approved these changes

@kawikabader kawikabader kawikabader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load locales to gasketData response Update intl v6 to use @gasket/data
3 participants
@kinetifex @burgessa23 @kawikabader