-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs site #116
Merged
Merged
Docs site #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinetifex
requested review from
cfellin1,
DullReferenceException,
indexzero and
SivanMehta
as code owners
November 27, 2019 05:59
DullReferenceException
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just have some nits. I would recommend reviewing these markdown files for proper document outline structure; I pointed out some, but not all cases where the header levels aren't correct.
cfellin1
approved these changes
Nov 27, 2019
kinetifex
pushed a commit
that referenced
this pull request
Dec 2, 2019
* [minor] stub out docsify site * [theme] init simple theme * [fix] link * [theme] continued iterations * [theme] temp repeating bg * [minor] move and set up gasket theme for docsify plugin * [theme] update site to pull from docsify plugin * [docs] readme alignment * [docs] readme alignment * [dist] disable oclif generated readme so we can hand-edit better * [site] iteration on cover page * [site] fix github logo * [fix] urls * [site] iteration * [site] mobile second * [site] make the top readme the index * [site] border angles * [site] fix border gap * [site] border slashes * [site] elements descr * [site] fix clip-path for safari * [site] update favicon and use in docs site * [site] fix external link svgs and css cleanup * [test] theme and config changes * [doc] changelog * [site] tweak stripes size * [site] point to slack signin app * [site] style tweaks * [dist] add extension to license files * [docs] add/fix license heading with links * [site] fixup nav issues * [fix] lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apologies for the size of this PR. This tackles a lot, but in short, this enables a docs site for Gasket using GitHub pages.
What is introduced is:
gasket docs
Changelog
repo
site/
files andindex.html
npm run docs-view
for local development@gasket/plugin-docsify
jsx
,json
,diff
,bash
Test Plan
Browse preview GitHub page in my fork: