Skip to content

Create dialog sample #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

Create dialog sample #22

merged 2 commits into from
Jun 23, 2022

Conversation

Jawnnypoo
Copy link
Contributor

This creates a dialog sample, to show its usage.
Screenshot_20220422_004941
Screenshot_20220422_004925

@Jawnnypoo Jawnnypoo mentioned this pull request Apr 22, 2022
Closed
ffgiraldez
ffgiraldez requested changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@ffgiraldez ffgiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, we don't use wildcard imports, apart from that code looks good to merge

@Jawnnypoo
Copy link
Contributor Author

Gotcha! Fixed now 👍

@ffgiraldez ffgiraldez merged commit 6ba7dde into godaddy:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffgiraldez ffgiraldez ffgiraldez approved these changes

+1 more reviewer

@ffranco-godaddy ffranco-godaddy ffranco-godaddy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jawnnypoo @ffgiraldez @ffranco-godaddy