Migrate Go server from AWS SDK v1 to AWS SDK v2#1488
Merged
Conversation
sushantmimani
approved these changes
Sep 3, 2025
Update server/go to use AWS SDK v2 for DynamoDB metastore operations, eliminating the last aws-sdk-go v1 dependency in the Go server implementation. - Replace awssession.Options with config.LoadDefaultConfig pattern - Update DynamoDB metastore initialization to use aws-v2 plugin - Migrate import statements from aws-sdk-go to aws-sdk-go-v2 - Maintain backward compatibility for all configuration options - Preserve existing error handling and panic recovery patterns
103c852 to
e90f3bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
This PR migrates the Go server (
server/go) from AWS SDK v1 to AWS SDK v2, completing the modernization of AWS dependencies across the Asherah project. The server now uses the same AWS SDK v2 plugins already available in the appencryption library.Changes
github.com/aws/aws-sdk-go v1.55.7and added AWS SDK v2 dependenciesawssession.Optionswithconfig.LoadDefaultConfigpatternplugins/aws-v2/dynamodb/metastoreBackward Compatibility
All existing server configuration options remain functional:
--dynamodb-endpoint--dynamodb-region--dynamodb-table-name--enable-region-suffixTechnical Details
The core changes are in
pkg/server/server.gowhere theNewMetastorefunction was updated to:config.LoadDefaultConfiginstead ofawssession.NewSessionWithOptionsdynamodb.NewFromConfigmetastore.NewDynamoDBfrom the aws-v2 pluginError handling patterns and panic recovery behavior are preserved to maintain operational consistency.