-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-2077 refactor gallery carousel to use tiny-swiper instead of flickity #2147
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
width: 62px; | ||
} | ||
|
||
&__next { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should group left and right styles that are shared.
&__prev,
&__next {
border: none;
padding: 15px;
...
}
&__prev {
left: 0;
}
&__next {
right: 0;
}
…cks into issue-2077-merge
Download coblocks.zip: https://37002-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2147.zip |
Looks great to me! A small difference that I see is that in the Editor side, there is no arrows on the side to switch from one image to another one. If that's an intended change, I don't see any other problem with it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if you want to merge!
Description
refactor the Gallery Carousel block to implement the tiny-swiper package as opposed to Flickity. this removes jQuery as a dependency of this block.
Screenshots
Types of changes
code refactor
How has this been tested?
Checklist: