Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Reap immediately after initialization on startup #58

Merged
merged 2 commits into from
Jul 29, 2017

Conversation

shdunning
Copy link
Collaborator

@shdunning shdunning commented Jul 27, 2017

Possible fix for #55.

These changes allow the first reap cycle to cleanup dead pools and any associated stale lock info. 2 main changes:

  • shorten the deadTime from 5 minutes to 10 seconds (2X heartbeat period)
  • first reap cycle begins after some initialization time during process startup (currently deadTime, or 10 seconds)
  • don't expire heartbeat keys ever, which delegates this responsibility to the reaper

@shdunning
Copy link
Collaborator Author

@tylerb can you try this out in your testing to see if it helps address #55 ?

@tylerstillwater
Copy link
Contributor

I'll give this a go and let you know. Thanks!

@tylerstillwater
Copy link
Contributor

@shdunning I have just deployed this and it appears to be working just fine. Thank you for taking a look. Much appreciated!

@shdunning
Copy link
Collaborator Author

Awesome, glad to hear it! I tested in our staging and it's behaving as expected. I'm going to merge this and close out issue #55.

@shdunning shdunning merged commit 2a383f8 into master Jul 29, 2017
@shdunning shdunning deleted the ReapAtStartup branch November 3, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants