Fix infinite worker loop preventing shutdown when Stop() called #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job fetch routine implements an infinite loop that pulls jobs as long as there are jobs to pull. If a backlog of jobs exists in the queue, and
Stop()is called, the worker never terminates. This will cause a program that is attempting to terminate to run indefinitely.This PR fixes the infinite loop and respects the
<-timer.Ccall in the select loop instead, giving thestopChananddrainChana chance to fire. Tests are provided to validate this issue is fixed.In addition, it fixes an issue with a test that hangs indefinitely if it cannot connect to redis.
This PR was, for the most part, already proposed, and much code was taken from that PR. I am submitting this PR to keep my fork in sync as I intend to send additional PRs in the future.