Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ON CONFLICT in InsertStmt #267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pablomatiasgomez
Copy link
Contributor

Add support for ON CONFLICT in InsertStmt

See section ON CONFLICT Clause in https://www.postgresql.org/docs/current/sql-insert.html for more reference

cc @santileira @taylorchu

@pablomatiasgomez
Copy link
Contributor Author

@taylorchu Thanks for merging the other PR! this one is ready for review too, not sure why I cannot tag you as reviewer

@pablomatiasgomez
Copy link
Contributor Author

@taylorchu do you think you will be able to review these? Sorry, I really don't want to be super noisy, I just want to know if I should wait for reviews or not 😅

@tinyzimmer
Copy link

Is there anything in particular holding up the merge of this? As a casual observer the code seems fine though my only gripe is that the expected input of action is a bit ambiguous looking from the outside in.

@pablomatiasgomez
Copy link
Contributor Author

Is there anything in particular holding up the merge of this? As a casual observer the code seems fine though my only gripe is that the expected input of action is a bit ambiguous looking from the outside in.

We didn't get any more answers so we decided to keep our own fork with more features, including this one. You can check it out here: https://github.com/embrace-io/dbr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants