-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix i18n dashboard language strings and allow customizing of permalink slugs #2593
Conversation
…eview prompt. Will test undoing these one by one to know what the bare minimum change is.
…nks for the settings page
…slugs, to avoid issues when visiting Settings > Permalink as a user with a different language than the site
…ership catalog is set
…point the defaults have already been loaded, so it has no effect.
… registration hook was fixed as part of this, as it did not run on activation.
@@ -89,9 +82,9 @@ private function __construct() { | |||
$this->query = new LLMS_Query(); | |||
|
|||
// Hooks. | |||
register_activation_hook( __FILE__, array( 'LLMS_Install', 'install' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The register_activation_hook
needs the main plugin filename. Since the class filename is being used here, this would never run. It's been moved into the main plugin file instead so the verify_permalinks
runs on activation.
Coverage reportCaution An unexpected error occurred. For more details, check console
Test suite run success169 tests passing in 22 suites. Report generated by 🧪jest coverage report action from e023c83 |
…tions under the current framework, they're not running reliably via github actions.
…language strings in an expected WP location.
Description
Various i18n fixes:
Fixes #2324
Fixes #2429
Fixes #2525
How has this been tested?
Manually. The current E2E doesn't permit tests before LifterLMS has been loaded, and switching languages was flaky.
Screenshots
Block translations showing Menu options and notices showing in the user language rather than the site language (French in this case) Settings > Permalink options to modify LifterLMS permalink slugs. Shows field added via `lifterlms-assignments` add-on.Checklist: