Reword commits that cause Prow warnings #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Corrected the typo of 'chck' with 'check' * Removed the duplicate sentence
* Update kustomization.md fix 404 urls in kustomization.md * Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md Co-Authored-By: Tim Bannister <tim@scalefactory.com> * update kustomization.md to be more stable
* update style guide for styling component names - Attempt to outline style conventions for components and component tools - Interested in comments and feedback * update style examples * style edits - removed code style for components not cmd tools - added style suggestion for namespaces - cleaned up a few stray spaces
Signed-off-by: umiblue <lentil1016@163.com>
* Add Gardener Project Update blog post * Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md * Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md
Fix grammar typo
After installing `cri-o`, we must run `systemctl daemon-reload` before trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know about the crio configuration. Similar instructions already exist for installing docker - this diff adds these instructions for crio.
* add CIDR * modify cidr definition * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <6834943+christophercarney@users.noreply.github.com> * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <6834943+christophercarney@users.noreply.github.com>
* specify components requiring feature gate currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to. * specify components requiring feature gate
* fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls
* Update guaranteed-scheduling-critical-addon-pods.md cleanup old stuff again * Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Update guaranteed-scheduling-critical-addon-pods.md remove whitespace
Co-Authored-By: Giri Kuncoro <girikuncoro@users.noreply.github.com> Co-Authored-By: Tim Bannister <tim@scalefactory.com>
gochist
pushed a commit
that referenced
this pull request
Jun 8, 2020
gochist
pushed a commit
that referenced
this pull request
Jun 8, 2020
Update kubespray page on kubernetes website
gochist
pushed a commit
that referenced
this pull request
Jun 8, 2020
ID Localization for Dual Stack IPv4/IPv6 #2. Fixed "anda" to "kamu". Adding "service" glossary. Fixed Hugo Build problem due to Glossary formatting. Fixed Typos and Glossary. Fixed Hugo Build problem. Fixing some translation words. Fixing bullet formatting. small change to re-initiate build. Fixed broken translation and word consistency. Fixed typo. Remove unnecessary file.
gochist
pushed a commit
that referenced
this pull request
Jun 8, 2020
ID Localization for Dual Stack IPv4/IPv6 #2. Fixed "anda" to "kamu". Adding "service" glossary. Fixed Hugo Build problem due to Glossary formatting. Fixed Typos and Glossary. Fixed Hugo Build problem. Fixing some translation words. Fixing bullet formatting. small change to re-initiate build. Fixed broken translation and word consistency. Fixed typo. Remove unnecessary file.
gochist
pushed a commit
that referenced
this pull request
Sep 11, 2020
Signed-off-by: Jubayer Abdullah Joy <jubayerjoy98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewords commits that cause Prow to apply
do-not-merge/invalid-commit-messagelabels to kubernetes#17958.I brought my local fork current with upstream/master:
I looked at the repo's commit history to find how far back I needed to edit. Then, in interactive mode, I reworded the commit messages for kubernetes#17888 and kubernetes#17889:
Specifically, I removed magic words from the commit messages and reduced them to a single line instead of multiple lines.
This PR includes many files and commits because I didn't
squashthe other commits; I did this to avoid unduly destructive history changes.UPDATE: This PR uses different hashes for each commit, compared to the current history in k/website. For example, the current branch tip for k/website is c26806c. This PR changes that hash to 5e730a3. Because this PR alters the earlier (and therefore subsequent) PR commit history, it makes sense to generate new hashes. Reviewers, please verify that commits from each PR apply changes correctly:
masterhashes